Slight refactor to collection widening #30076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Nov 18, 2018
|
Ok |
|
Wait, I'm confused.... adding the |
|
IIRC, |
|
Oh ok |
|
Well it looks like this is passing. Is it worth running benchmarks? |
|
I like this. I hope this pattern will be easier to replicate in custom array code and custom operations on containers. Currently I find implementing a “widening” approach instead of a “inference” approach to container allocation quite tiresome, but I think this could help immensely. |
fredrikekre
reviewed
Nov 20, 2018
andyferris
reviewed
Nov 20, 2018
nalimilan
reviewed
Nov 21, 2018
|
Ok I think I've addressed all the comments |
|
Good? |
andyferris
approved these changes
Nov 29, 2018
Open
|
Is this backsportable? |
|
No, its not a bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out specifically collection widening to its own functions. This will allow overloading these functions for data-structures which are easier to widen than Arrays, e.g. ModelArrays (see #13942)
The eltype checks seem redundant but help make the functions more generalizable. I think they're costless anyway.